vibhatha commented on code in PR #41636:
URL: https://github.com/apache/arrow/pull/41636#discussion_r1600782612
##########
java/vector/src/main/java/org/apache/arrow/vector/compare/RangeEqualsVisitor.java:
##########
@@ -450,6 +454,77 @@ protected boolean
compareBaseLargeVariableWidthVectors(Range range) {
return true;
}
+ protected boolean compareBaseVariableWidthViewVectors(Range range) {
+ BaseVariableWidthViewVector leftVector = (BaseVariableWidthViewVector)
left;
+ BaseVariableWidthViewVector rightVector = (BaseVariableWidthViewVector)
right;
+
+ final ArrowBuf leftViewBuffer = leftVector.getDataBuffer();
+ final ArrowBuf rightViewBuffer = rightVector.getDataBuffer();
+
+ final int elementSize = BaseVariableWidthViewVector.ELEMENT_SIZE;
+ final int lengthWidth = BaseVariableWidthViewVector.LENGTH_WIDTH;
+ final int prefixWidth = BaseVariableWidthViewVector.PREFIX_WIDTH;
+ final int bufIndexWidth = BaseVariableWidthViewVector.BUF_INDEX_WIDTH;
+
+ for (int i = 0; i < range.getLength(); i++) {
+ int leftIndex = range.getLeftStart() + i;
+ int rightIndex = range.getRightStart() + i;
+
+ boolean isNull = leftVector.isNull(leftIndex);
+ if (isNull != rightVector.isNull(rightIndex)) {
+ return false;
+ }
+
+ int startIndexLeft = leftIndex * elementSize;
+ int endIndexLeft = (leftIndex + 1) * elementSize;
+
+ int startIndexRight = rightIndex * elementSize;
+ int endIndexRight = (rightIndex + 1) * elementSize;
+
+ // check equality of the view
+ int retView = ByteFunctionHelpers.equal(leftViewBuffer, startIndexLeft,
endIndexLeft,
+ rightViewBuffer, startIndexRight, endIndexRight);
Review Comment:
Yes. Good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
