CurtHagenlocher commented on code in PR #1865: URL: https://github.com/apache/arrow-adbc/pull/1865#discussion_r1601751710
########## csharp/src/Apache.Arrow.Adbc/AdbcDriver11.cs: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +using System; +using System.Collections.Generic; + +namespace Apache.Arrow.Adbc +{ + /// <summary> + /// This provides a common interface for vendor-specific driver + /// initialization routines. + /// </summary> + public abstract class AdbcDriver11 : IDisposable + { + ~AdbcDriver11() => Dispose(false); + + /// <summary> + /// Returns the version of the ADBC spec supported by this driver. + /// </summary> + public virtual int Version => AdbcVersion.Version_1_0_0; + + /// <summary> + /// Open a database via this driver. + /// </summary> + /// <param name="parameters">Driver-specific parameters.</param> + public abstract AdbcDatabase Open(IReadOnlyDictionary<string, string> parameters); Review Comment: This is similar to CreateStatement. I see an ADBC database as being a bookkeeping thing; more like a connection string than something that's actually connected to anything. Through that interpretation, the name "Open" is misleading here and should probably be replaced. If we change this for CreateStatement now then we'd change this here as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
