danepitkin commented on PR #40761: URL: https://github.com/apache/arrow/pull/40761#issuecomment-2113062919
Hi @llama90 , I filed the original issue. Your PR is reimplementing too many things. This issue was originally filed due to this comment: https://github.com/apache/arrow/pull/40265/files#r1505826814 To help clarify, we don't want to reimplement all of the type checks. Instead, we want to investigate if we can replace these python-defined vars https://github.com/apache/arrow/blob/e1de9c52d5a60b2e2a314b8589170467fe36415d/python/pyarrow/types.py#L29-L46 with checks that might already exist in C++. For example, can we replace this line https://github.com/apache/arrow/blob/e1de9c52d5a60b2e2a314b8589170467fe36415d/python/pyarrow/types.py#L177 with an existing Arrow C++ function that we could expose via cython. Let me know if that helps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
