jduo commented on code in PR #1863:
URL: https://github.com/apache/arrow-adbc/pull/1863#discussion_r1602045485
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Connection.cs:
##########
@@ -46,6 +49,30 @@ internal TCLIService.Client Client
get { return this.client ?? throw new
InvalidOperationException("connection not open"); }
}
+ protected string? VendorVersion
+ {
+ get
+ {
+ if (_vendorVersion == null &&
TryGetInfoType(TGetInfoType.CLI_DBMS_VER, out string? value))
+ {
+ _vendorVersion = value;
+ }
+ return _vendorVersion;
+ }
+ }
+
+ protected string? VendorName
+ {
+ get
+ {
+ if (_vendorName == null &&
TryGetInfoType(TGetInfoType.CLI_DBMS_NAME, out string? value))
Review Comment:
If there's an error getting the info type, this will attempt to get it again
every time the VendorName property is used. Is this the desired behavior, or
should we track it (say the error isn't transient but perhaps the backend isn't
reporting this field).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
