amoeba commented on PR #41593: URL: https://github.com/apache/arrow/pull/41593#issuecomment-2113624589
Hey @AlenkaF, this is so great to see. I think the text and diagrams will be useful. I left some suggestions for style and: - Did an editing pass over the text. Feel free to ignore any you don't like. - I'm a bit late in the process here but I noticed in the diagrams that we use `-` for null. It kinda looks like a minus symbol sometimes instead of indicating a missing element. I wonder if a `_` or `?` might be more clear? I realize part of the issue here is due to limitations of Excalidraw. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
