amoeba commented on PR #40392: URL: https://github.com/apache/arrow/pull/40392#issuecomment-2113695113
Thanks @pitrou for the review. I rebased from apache/main, accepted your three changes as-is, and added one extra change I caught while dealing with conflicts on rebase, 4bd0339e596d410bd5ad3a73f06d9294c7a87e7f. In https://github.com/apache/arrow/commit/4c8eff2ec8bae76364fcb28ffac574c1df262705 @kou tweaked the CMakeList and I think this PR should make the same change as was made there. PS: After pushing I found the ipc/CMakeLists.txt needed formatting, so that was added here too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
