lidavidm commented on code in PR #41676:
URL: https://github.com/apache/arrow/pull/41676#discussion_r1602517022
##########
java/vector/src/main/java/org/apache/arrow/vector/VectorLoader.java:
##########
@@ -98,7 +98,7 @@ private void loadBuffers(
CompressionCodec codec) {
checkArgument(nodes.hasNext(), "no more field nodes for field %s and
vector %s", field, vector);
ArrowFieldNode fieldNode = nodes.next();
- int bufferLayoutCount = TypeLayout.getTypeBufferCount(field.getType());
+ int bufferLayoutCount = TypeLayout.getTypeBufferCount(field.getType(),
vector);
Review Comment:
That means we're just blindly trusting the input.
I recommend reviewing the spec again...
https://github.com/apache/arrow/blob/main/format/Message.fbs#L117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
