pitrou commented on PR #41477: URL: https://github.com/apache/arrow/pull/41477#issuecomment-2115190785
I don't really understand what the purpose of this PR is. It claims that slicing a Buffer is overkill, but I'm a bit skeptical: are there really situations where the overhead would be unacceptable? Especially, the `CopyBufferSlice` implementation is always first calling `ViewBufferTo`, then falls back to `CopyBufferTo` (both of which instantiate a `std::shared_ptr<Buffer>`), then does a `memcpy` always. If the data length is small, this is still considerable overhead. If the data length is large, then we're doing a spurious copy compared to `ViewOrCopy`... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
