tustvold commented on code in PR #5773:
URL: https://github.com/apache/arrow-rs/pull/5773#discussion_r1603304793
##########
parquet_derive/src/parquet_field.rs:
##########
@@ -638,17 +636,38 @@ impl Type {
}
"f32" => BasicType::FLOAT,
"f64" => BasicType::DOUBLE,
- "String" | "str" | "Uuid" => BasicType::BYTE_ARRAY,
+ "String" | "str" => BasicType::BYTE_ARRAY,
+ "Uuid" => BasicType::FIXED_LEN_BYTE_ARRAY,
f => unimplemented!("{} currently is not supported", f),
}
}
+ fn length(&self) -> Option<syn::Expr> {
+ let last_part = self.last_part();
+ let leaf_type = self.leaf_type_recursive();
+
+ // `[u8; N]` => Some(N)
+ if let Type::Array(ref first_type, length) = leaf_type {
Review Comment:
Could we possibly get a test for this logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
