pitrou commented on code in PR #41564:
URL: https://github.com/apache/arrow/pull/41564#discussion_r1603499276


##########
cpp/src/arrow/filesystem/s3fs_test.cc:
##########
@@ -1197,6 +1199,19 @@ TEST_F(TestS3FS, OpenOutputStreamSyncWrites) {
   TestOpenOutputStream();
 }
 
+TEST_F(TestS3FS, OpenOutputStreamNoBucketSanitizationSyncWrites) {

Review Comment:
   Instead of adding more test methods for every combinatorial expansion, 
perhaps we should instead use a `for` loop on the various tested parameter 
values?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to