raulcd commented on code in PR #41131:
URL: https://github.com/apache/arrow/pull/41131#discussion_r1604147006
##########
.github/workflows/dev.yml:
##########
@@ -124,6 +124,7 @@ jobs:
- name: Run Release Test
env:
ARROW_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Review Comment:
why is this `GH_TOKEN` necessary now?
##########
.github/workflows/release_candidate.yml:
##########
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Release
+
+on:
+ push:
+ tags:
+ # Trigger workflow when a tag whose name matches the pattern
+ #"apache-arrow-{MAJOR}.{MINOR}.{PATCH}-rc{RC_NUM}" is pushed.
+ - "apache-arrow-[0-9]+.[0-9]+.[0-9]+-rc[0-9]+"
+
+permissions:
+ contents: write
+
+env:
+ GH_TOKEN: ${{ github.token }}
Review Comment:
again, is this necessary?
##########
.github/workflows/release.yml:
##########
@@ -0,0 +1,78 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Release
+
+on:
+ push:
+ tags:
+ # Trigger workflow when a tag whose name matches the pattern
+ # pattern "apache-arrow-{MAJOR}.{MINOR}.{PATCH}" is pushed.
+ - "apache-arrow-[0-9]+.[0-9]+.[0-9]+"
+
+permissions:
+ contents: write
+
+env:
+ GH_TOKEN: ${{ github.token }}
+
+jobs:
+ publish:
+ name: Publish
+ runs-on: ubuntu-latest
+ timeout-minutes: 5
+ steps:
+ - name: Checkout Arrow
Review Comment:
As far as I understand cloning arrow is not necessary on this workflow as we
are just downloading the release from the artifacts created for the RC and
uploading the final release.
##########
.github/workflows/release.yml:
##########
@@ -0,0 +1,78 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Release
+
+on:
+ push:
+ tags:
+ # Trigger workflow when a tag whose name matches the pattern
+ # pattern "apache-arrow-{MAJOR}.{MINOR}.{PATCH}" is pushed.
+ - "apache-arrow-[0-9]+.[0-9]+.[0-9]+"
+
+permissions:
+ contents: write
+
+env:
+ GH_TOKEN: ${{ github.token }}
Review Comment:
is this necessary?
##########
docs/source/developers/release.rst:
##########
@@ -200,6 +200,8 @@ Build source and binaries and submit them
.. code-block::
# Build the source release tarball and create Pull Request with
verification tasks
+ #
+ # Note that you need to have GitHub CLI installed to run this script.
Review Comment:
Should we add a note here saying that we have to wait for the workflow to
finish creating the Release on GH before executing this? I usually execute
those two scripts one after the other and if there is a minor queue on the
runners and the release is not created this execution will fail to download the
`tar.gz`. Adding a note to the release manager to validate the release is
created could help prevent that.
##########
.github/workflows/release.yml:
##########
@@ -0,0 +1,78 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Release
+
+on:
+ push:
+ tags:
+ # Trigger workflow when a tag whose name matches the pattern
+ # pattern "apache-arrow-{MAJOR}.{MINOR}.{PATCH}" is pushed.
+ - "apache-arrow-[0-9]+.[0-9]+.[0-9]+"
+
+permissions:
+ contents: write
+
+env:
+ GH_TOKEN: ${{ github.token }}
+
+jobs:
+ publish:
+ name: Publish
+ runs-on: ubuntu-latest
+ timeout-minutes: 5
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ - name: Get Tag Name of Latest Release Candidate
+ run: |
+ rc_tag=$(gh release list | \
+ cut -f3 | \
+ grep -F "${GITHUB_REF_NAME}-rc" | \
+ head -n1)
+ echo "Latest Release Candidate Tag: ${rc_tag}"
+ echo "RELEASE_CANDIDATE_TAG_NAME=${rc_tag}" >> ${GITHUB_ENV}
+ - name: Store Version and Release Candidate Number
+ run: |
+ version_with_rc=${RELEASE_CANDIDATE_TAG_NAME#apache-arrow-}
+ version=${version_with_rc%-rc*}
+ rc_num=${version_with_rc#${version}-rc}
+ echo "VERSION_WITH_RC=${version_with_rc}" >> ${GITHUB_ENV}
+ echo "VERSION=${version}" >> ${GITHUB_ENV}
+ echo "RC_NUM=${rc_num}" >> ${GITHUB_ENV}
+ - name: Download Release Candidate Artifacts
+ run: |
+ mkdir release_candidate_artifacts
+ gh release download ${RELEASE_CANDIDATE_TAG_NAME} --dir
release_candidate_artifacts
+ - name: Create Release Title
+ run: |
+ title="Apache Arrow ${VERSION}"
+ echo "RELEASE_TITLE=${title}" >> ${GITHUB_ENV}
+ - name: Create Release Notes
+ run: |
+ release_notes="https://arrow.apache.org/release/${VERSION}.html";
Review Comment:
the release notes are uploaded on the 4th step of the post release process
instead and the tag is created on the first step. I don't think there's a
problem with this but this link won't exist until the the website is updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
