felipecrv commented on code in PR #41449:
URL: https://github.com/apache/arrow/pull/41449#discussion_r1604261212
##########
cpp/src/arrow/compute/api_scalar.cc:
##########
@@ -480,10 +481,11 @@ NullOptions::NullOptions(bool nan_is_null)
: FunctionOptions(internal::kNullOptionsType), nan_is_null(nan_is_null) {}
constexpr char NullOptions::kTypeName[];
-PadOptions::PadOptions(int64_t width, std::string padding)
+PadOptions::PadOptions(int64_t width, std::string padding, bool
align_left_on_odd_padding)
: FunctionOptions(internal::kPadOptionsType),
width(width),
- padding(std::move(padding)) {}
+ padding(std::move(padding)),
+ align_left_on_odd_padding(align_left_on_odd_padding) {}
Review Comment:
You could call it `leftist` or `leftist_on_odd_padding`. No joke.
https://en.wikipedia.org/wiki/Leftist_tree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
