OliLay commented on code in PR #41564:
URL: https://github.com/apache/arrow/pull/41564#discussion_r1604483833
##########
cpp/src/arrow/filesystem/s3fs.cc:
##########
@@ -1734,7 +1812,7 @@ class ObjectOutputStream final : public io::OutputStream {
return Status::OK();
}
- // Upload current buffer
+ // Upload current buffer if we are above threshold for multi-part upload
Review Comment:
You're right, I just wanted to make the point that we won't call this when
we haven't accumulated enough data. I've clarified the comment.
[7748824](https://github.com/apache/arrow/pull/41564/commits/77488243b71be6688e9131efac03e9b98d14b1bd)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
