felipecrv commented on PR #41700: URL: https://github.com/apache/arrow/pull/41700#issuecomment-2117838394
> May I ask a unrelated question, when would we call assert and when call DCHECK, since I think they would likely to be same? We call assert in headers because we don't want to pay the cost of including `logging.h` everywhere. Think of `assert` as lighter-weight debug checks. But if you see an assert in a `.cc` file tell me to change it to `DCHECK*`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
