tustvold commented on code in PR #5779:
URL: https://github.com/apache/arrow-rs/pull/5779#discussion_r1605215957


##########
arrow-cast/src/cast/mod.rs:
##########
@@ -153,6 +153,8 @@ pub fn can_cast_types(from_type: &DataType, to_type: 
&DataType) -> bool {
         (_, LargeList(list_to)) => can_cast_types(from_type, 
list_to.data_type()),
         (_, FixedSizeList(list_to,size)) if *size == 1 => {
             can_cast_types(from_type, list_to.data_type())},
+        (FixedSizeList(list_from,size), _) if *size == 1 => {

Review Comment:
   I think this could recurse infinitely if you tried to cast a FixedSizeList 
of type A to a FixedSizeList of type B



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to