anjakefala commented on code in PR #41041:
URL: https://github.com/apache/arrow/pull/41041#discussion_r1605496443
##########
python/setup.py:
##########
@@ -480,47 +455,14 @@ def has_ext_modules(foo):
setup(
- name='pyarrow',
packages=packages,
- zip_safe=False,
- package_data={'pyarrow': ['*.pxd', '*.pyx', 'includes/*.pxd']},
- include_package_data=True,
exclude_package_data=exclude_package_data,
distclass=BinaryDistribution,
# Dummy extension to trigger build_ext
ext_modules=[Extension('__dummy__', sources=[])],
cmdclass={
'build_ext': build_ext
},
- use_scm_version={
- 'root': os.path.dirname(setup_dir),
- 'parse': parse_git,
- 'write_to': os.path.join(scm_version_write_to_prefix,
- 'pyarrow/_generated_version.py'),
- 'version_scheme': guess_next_dev_version
- },
- setup_requires=['setuptools_scm', 'cython >= 0.29.31'] + setup_requires,
- install_requires=install_requires,
tests_require=['pytest', 'pandas', 'hypothesis'],
Review Comment:
> So if we do add this extra, we should use an up to date list of actual
test dependencies)
So rather than it comprehensively installing all of the dependencies that
any test might rely on, you only want the non-optional ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
