zanmato1984 commented on PR #41234: URL: https://github.com/apache/arrow/pull/41234#issuecomment-2119686270
I have a question about the necessity of this fix. IIUC, though `RowTableImpl` supports both usages of columns "in encoding order" and "not in encoding order", the user (e.g. `Grouper` or `SwissJoin`) is free to choose either, in other words, the user is not mandatory to support both. For example, the current `SwissJoin` is using it the way that all columns are assumed "not in encoding order" and it is perfectly fine because there isn't a case that requires `SwissJoin` to do it the other way. The same goes to `Grouper` as well. Is there a reason that `Grouper` must assume the columns are not in encoding order, or that `Grouper` can benefit in terms of performance/complexity from treating the columns not in encoding order? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
