tustvold commented on code in PR #5785:
URL: https://github.com/apache/arrow-rs/pull/5785#discussion_r1606551692
##########
arrow-json/src/writer.rs:
##########
@@ -1565,6 +1565,85 @@ mod tests {
Ok(())
}
+ macro_rules! binary_encoding_test {
Review Comment:
I prefer generally prefer generics over test macros as they're easier to
debug and maintain, in this case it should be relatively straightforward to
write a generic function on the offset type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
