tustvold commented on code in PR #5769:
URL: https://github.com/apache/arrow-rs/pull/5769#discussion_r1606571194


##########
arrow-integration-test/src/lib.rs:
##########
@@ -387,6 +398,25 @@ pub fn array_from_json(
                     1 => b.append_value(match value {
                         Value::Number(n) => n.as_i64().unwrap(),
                         Value::String(s) => s.parse().expect("Unable to parse 
string as i64"),
+                        _ => panic!("Unable to parse {value:?} as number"),

Review Comment:
   Yeah, this code was originally written solely for tests, and so is quite 
panic happy



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to