FiV0 commented on code in PR #41731:
URL: https://github.com/apache/arrow/pull/41731#discussion_r1606681649


##########
java/vector/src/main/codegen/templates/BaseWriter.java:
##########
@@ -61,20 +61,25 @@ public interface StructWriter extends BaseWriter {
 

Review Comment:
   This is where some design decisions have to be made of how to actually 
expose the `ExtensionWriter` to the user and how the user should actually 
extend some `ExtensionWriter`. 
   
   As mentioned above I would make this one interface `BaswWriter` exposing all 
the possible writers and leaving them abstract in the concrete implementations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to