adamreeve commented on code in PR #41750:
URL: https://github.com/apache/arrow/pull/41750#discussion_r1607804366
##########
c_glib/arrow-dataset-glib/dataset.cpp:
##########
@@ -152,12 +153,43 @@ gadataset_dataset_to_table(GADatasetDataset *dataset,
GError **error)
}
auto arrow_scanner = *arrow_scanner_result;
auto arrow_table_result = arrow_scanner->ToTable();
- if (!garrow::check(error, arrow_scanner_result, "[dataset][to-table]")) {
+ if (!garrow::check(error, arrow_table_result, "[dataset][to-table]")) {
Review Comment:
This is an unrelated change but I noticed this was checking the wrong
result, so if `arrow_scanner_builder->Finish()` succeeded but
`arrow_scanner->ToTable()` failed the error would not have been correctly
caught.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
