bkietz commented on a change in pull request #9457:
URL: https://github.com/apache/arrow/pull/9457#discussion_r581067326
##########
File path: dev/archery/archery/benchmark/google.py
##########
@@ -67,8 +67,7 @@ def results(self, repetitions=1):
class GoogleBenchmarkObservation:
""" Represents one run of a single (google c++) benchmark.
- Observations are found when running with `--benchmark_repetitions`. Sadly,
- the format mixes values and aggregates, e.g.
+ Aggregates are reported when running with `--repetitions`.
Review comment:
```suggestion
Aggregates are reported by Google Benchmark executables
alongside other observations whenever repetitions are specified
(with `--benchmark_repetitions` on the bare benchmark, or with
the archery option `--repetitions`). Aggregate observations are
not included in `GoogleBenchmark.runs`.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
