lidavidm commented on code in PR #1803:
URL: https://github.com/apache/arrow-adbc/pull/1803#discussion_r1609054941
##########
.github/workflows/rust.yml:
##########
@@ -42,11 +42,16 @@ defaults:
working-directory: rust
jobs:
+ native-unix:
+ uses: ./.github/workflows/native-unix.yml
+
rust:
+ needs: [native-unix]
strategy:
matrix:
- # TODO(lidavidm): add back macos-latest once it has Cargo installed
- os: [windows-latest, macos-13, ubuntu-latest]
+ # TODO(alexandreyc): add `windows-latest`
+ # See:
https://github.com/apache/arrow-adbc/pull/1803#issuecomment-2117669300
+ os: [macos-latest, ubuntu-latest]
Review Comment:
Keep macos-13, or else we aren't testing on x64 macos?
##########
python/adbc_driver_flightsql/tests/test_errors.py:
##########
@@ -186,7 +186,8 @@ def test_query_error_getflightinfo(test_dbapi):
cur.adbc_execute_partitions("error_get_flight_info")
-def test_stateless_prepared_statement(test_dbapi) -> None:
- with test_dbapi.cursor() as cur:
- cur.adbc_prepare("stateless_prepared_statement")
- cur.execute("stateless_prepared_statement", parameters=[(1,)])
+# TODO: fix this flaky test (EOF error)
+# def test_stateless_prepared_statement(test_dbapi) -> None:
+# with test_dbapi.cursor() as cur:
+# cur.adbc_prepare("stateless_prepared_statement")
+# cur.execute("stateless_prepared_statement", parameters=[(1,)])
Review Comment:
Please just leave this...it will just get forgotten otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
