TheNeuralBit commented on PR #41769:
URL: https://github.com/apache/arrow/pull/41769#issuecomment-2125302984

   > This fixing looks nice to me, but I'm a bit confused why 
`schema.metadata()` is extracted to file-metadata
   
   I agree this is a little surprising. Is there some other way to use 
`FileWriter` to write key-value metadata to the parquet file metadata? This was 
the first method I found.
   
   Regardless I think we should be consistent between the store_schema true and 
false paths. Right now one copies the schema metadata to parquet file-level 
metadata and one does not. An alternative could be to change the store_schema 
true path (and document an alternative way to write file-level metadata) but 
that's more likely to be a breaking change I think.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to