zanmato1984 commented on code in PR #41125:
URL: https://github.com/apache/arrow/pull/41125#discussion_r1610910678
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -1425,31 +1431,86 @@ class AsofJoinNode : public ExecNode {
// The reason for this is that there are cases at the end of a table where
we don't
// know whether the RHS of the join is up-to-date until we know that the
table is
// finished.
- process_.Push(true);
+ PushProcess(true);
+
return Status::OK();
}
+ void PushProcess(bool value) {
+#ifdef ARROW_ENABLE_THREADING
+ process_.Push(value);
+#else
+ if (value) {
+ ProcessNonThreaded();
+ }
Review Comment:
I have the same concern. For the threaded version, a poison pill will
effectively lead to a cleanup (`EndFromProcessThread`) in both asof join (in
`ProcessThread`) and sorted merge join (in `EmitBatches`). I think this is
necessary for cases when upstream calls `StopProducing` which takes a poison
pill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
