vibhatha commented on code in PR #41732:
URL: https://github.com/apache/arrow/pull/41732#discussion_r1611371095
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowRecordBatch.java:
##########
@@ -121,6 +123,65 @@ public ArrowRecordBatch(
}
}
this.buffersLayout = Collections.unmodifiableList(arrowBuffers);
+ this.variadicBufferCounts = null;
+ }
+
+ /**
+ * Construct a record batch from nodes.
+ *
+ * @param length how many rows in this batch
+ * @param nodes field level info
+ * @param buffers will be retained until this recordBatch is closed
+ * @param bodyCompression compression info.
+ * @param variadicBufferCounts the number of buffers in each variadic
section.
+ * @param alignBuffers Whether to align buffers to an 8 byte boundary.
+ */
+ public ArrowRecordBatch(
+ int length, List<ArrowFieldNode> nodes, List<ArrowBuf> buffers,
+ ArrowBodyCompression bodyCompression, List<Long> variadicBufferCounts,
boolean alignBuffers) {
+ this(length, nodes, buffers, bodyCompression, variadicBufferCounts,
alignBuffers, /*retainBuffers*/ true);
+ }
+
+ /**
+ * Construct a record batch from nodes.
+ *
+ * @param length how many rows in this batch
+ * @param nodes field level info
+ * @param buffers will be retained until this recordBatch is closed
+ * @param bodyCompression compression info.
+ * @param variadicBufferCounts the number of buffers in each variadic
section.
+ * @param alignBuffers Whether to align buffers to an 8 byte boundary.
+ * @param retainBuffers Whether to retain() each source buffer in the
constructor. If false, the caller is
+ * responsible for retaining the buffers beforehand.
+ */
+ public ArrowRecordBatch(
+ int length, List<ArrowFieldNode> nodes, List<ArrowBuf> buffers,
+ ArrowBodyCompression bodyCompression, List<Long> variadicBufferCounts,
boolean alignBuffers,
+ boolean retainBuffers) {
+ super();
Review Comment:
I updated, is it fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
