tustvold opened a new pull request, #5796:
URL: https://github.com/apache/arrow-rs/pull/5796
_Draft as needs more testing, creating for feedback_
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Relates to #5736
Relates to #5530
Relates to #5735
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Whilst working on #5736 I struggled to devise a coherent interface for
constructing byte views, because views can't really really be constructed
independently of the data buffers. In particular small strings need to be
inlined in the view, but longer strings need to be added to a data buffer. As a
result any interface that exposes the view abstraction is naturally leaky, and
quite fiddly to use correctly.
Fortunately we already have a builder that abstracts away the view
shenanigans, and with some minor tweaks we can extend it to allow using
existing buffers, I think this provides for a much more coherent abstraction.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
