pitrou commented on code in PR #40807: URL: https://github.com/apache/arrow/pull/40807#discussion_r1611654558
########## cpp/src/arrow/record_batch.h: ########## @@ -23,6 +23,7 @@ #include <vector> #include "arrow/compare.h" +#include "arrow/device.h" Review Comment: I think at least moving `DeviceAllocationType` to `type_fwd.h` would make sense. As for `Device::SyncEvent`, that's indeed a problem with nested classes (and a good reason to avoid them :-)). That could be fixed by moving `SyncEvent` out of `Device` and adding a compatibility alias. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
