kou commented on code in PR #41599:
URL: https://github.com/apache/arrow/pull/41599#discussion_r1612517256
##########
ci/scripts/install_vcpkg.sh:
##########
@@ -25,7 +25,7 @@ if [ "$#" -lt 1 ]; then
fi
arrow_dir=$(cd -- "$(dirname -- "$0")/../.." && pwd -P)
-default_vcpkg_version=$(cat "${arrow_dir}/.env" | grep "VCPKG" | cut -d "="
-f2 | tr -d '"')
+default_vcpkg_version=$(source "${arrow_dir}/.env" && echo "$VCPKG" || echo "")
Review Comment:
Can we remove `|| echo ""` ?
```suggestion
default_vcpkg_version=$(source "${arrow_dir}/.env" && echo "$VCPKG")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
