nealrichardson commented on a change in pull request #9521:
URL: https://github.com/apache/arrow/pull/9521#discussion_r581431268
##########
File path: r/R/dplyr.R
##########
@@ -309,8 +344,27 @@ collect.arrow_dplyr_query <- function(x, as_data_frame =
TRUE, ...) {
# See dataset.R for Dataset and Scanner(Builder) classes
Review comment:
Per https://dplyr.tidyverse.org/reference/compute.html, `compute()
stores results in a remote temporary table.` I'm not sure that's appropriate
here (though I'm not sure it's not). I would think in our context that would
entail something like
```
compute.arrow_dplyr_query <- function(x, name, ...) assign(name,
collect.arrow_dplyr_query(x, as_data_frame = FALSE))
```
which I'm not opposed to having, but I don't think that's a replacement for
this functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
