adamreeve opened a new pull request, #41805:
URL: https://github.com/apache/arrow/pull/41805

   ### Rationale for this change
   
   See https://github.com/apache/arrow/pull/41599#discussion_r1612517256
   
   This is a small tidy up of `install_vcpkg.sh` based on code review in #41599 
after it was merged. Some uses of `install_vcpkg.sh` are in Docker containers 
where the `.env` file hasn't been copied. Rather than try to read it and ignore 
any errors, only read the `.env` file if the vcpkg version wasn't specified as 
an argument to the script. This way if there is an error reading the `.env` 
file and we do need the default version, the error should be more helpful.
   
   ### What changes are included in this PR?
   
   Update `install_vcpkg.sh` to only try to read the vcpkg version from `.env` 
if it isn't specified as an argument and don't ignore any errors.
   
   ### Are these changes tested?
   
   Yes, this script already runs as part of CI.
   
   ### Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to