Julian-Brandrick commented on code in PR #1870:
URL: https://github.com/apache/arrow-adbc/pull/1870#discussion_r1613778474
##########
csharp/Directory.Build.props:
##########
@@ -29,7 +29,7 @@
<Product>Apache Arrow ADBC library</Product>
<Copyright>Copyright 2022-2024 The Apache Software Foundation</Copyright>
<Company>The Apache Software Foundation</Company>
- <Version>1.0.0</Version>
+ <VersionPrefix>1.0.0</VersionPrefix>
Review Comment:
Through testing, dotnet pack --version-suffix does override the
VersionSuffix in the props file:
- Adding <VersionSuffix>SNAPSHOT</VersionSuffix> and not specifying
-versionSuffix results in "1.0.0-SNAPSHOT".
- Adding <VersionSuffix>SNAPSHOT</VersionSuffix> and specifying
-versionSuffix "prerelease" results in "1.0.0-prerelease".
I'll add the SNAPSHOT VersionSuffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
