awalga opened a new pull request, #41865:
URL: https://github.com/apache/arrow/pull/41865
…sh aggregate function & kernel signature.
### Rationale for this change
Current implementation does not allow for resolution of hash aggregate
kernel with signature containing var args example {int64...}.
The resolution fails because a uint32 (group_id_array) is appended to the
argument list of the kernel signature {int64...} -> {int64...,uint32}.
This PR modify the ordering and moves the group_id_array to position 0,
allowing for resolution of hash aggregate function with var args.
This simplify implementation of kernel of type:
sum(product(x,y))
sum(product(x,y,z))
into a single kernel
sum(product(x...))
### What changes are included in this PR?
### Are these changes tested?
Yes previous test covers existing hash aggregate kernels.
A test verifiying a valid Declaration can be produced with a var args hash
aggregate is added.
### Are there any user-facing changes?
**This PR includes breaking changes to public APIs.**
This should not break public APIs (to my knowledge), tough there is an api
leak in python wrapper (python/pyarrow/src/arrow/python/udf.cc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
