alamb commented on code in PR #5811:
URL: https://github.com/apache/arrow-rs/pull/5811#discussion_r1617614226
##########
arrow-row/src/lib.rs:
##########
@@ -2271,4 +2263,16 @@ mod tests {
dictionary_eq(&back[0], &array);
}
+
+ #[test]
Review Comment:
I verified that this test covers the issue by running this test on main and
it failed like this:
```shell
thread 'tests::test_list_prefix' panicked at arrow-row/src/lib.rs:2284:9:
assertion `left == right` failed
left: Greater
right: Less
stack backtrace:
0: rust_begin_unwind
at
/rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:645:5
1: core::panicking::panic_fmt
at
/rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/panicking.rs:72:14
2: core::panicking::assert_failed_inner
3: core::panicking::assert_failed
at
/rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/panicking.rs:298:5
4: arrow_row::tests::test_list_prefix
at ./src/lib.rs:2284:9
5: arrow_row::tests::test_list_prefix::{{closure}}
at ./src/lib.rs:2276:26
6: core::ops::function::FnOnce::call_once
at
/rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
7: core::ops::function::FnOnce::call_once
at
/rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose
backtrace.
error: test failed, to rerun pass `--lib`
error: 1 target failed:
`--lib`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
