lidavidm commented on code in PR #39777:
URL: https://github.com/apache/arrow/pull/39777#discussion_r1618155768
##########
java/format/src/main/java/org/apache/arrow/flatbuf/Binary.java:
##########
Review Comment:
These should be excluded? They're generated code.
##########
java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfigTest.java:
##########
@@ -89,17 +90,17 @@ public void testConfig() {
JdbcToArrowConfigBuilder builder = new JdbcToArrowConfigBuilder(allocator,
calendar);
JdbcToArrowConfig config = builder.build();
- assertTrue(allocator == config.getAllocator());
- assertTrue(calendar == config.getCalendar());
+ assertTrue(Objects.equals(allocator, config.getAllocator()));
Review Comment:
assertEquals
##########
java/memory/memory-core/src/test/java/org/apache/arrow/memory/TestBaseAllocator.java:
##########
@@ -1077,8 +1077,6 @@ public void testMemoryLeakWithReservation() throws
Exception {
"child2", 1024, MAX_ALLOCATION);
rootAllocator.verify();
- ArrowBuf buff = childAllocator2.buffer(256);
Review Comment:
Er, these have side effects. Do not delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
