emkornfield commented on code in PR #41765:
URL: https://github.com/apache/arrow/pull/41765#discussion_r1619024978
##########
cpp/src/parquet/types.cc:
##########
@@ -464,7 +464,10 @@ std::shared_ptr<const LogicalType> LogicalType::FromThrift(
} else if (type.__isset.FLOAT16) {
return Float16LogicalType::Make();
} else {
- throw ParquetException("Metadata contains Thrift LogicalType that is not
recognized");
+ // Or provide some mechanism to optionally error here?
Review Comment:
If we don't throw here at the very least we need to ignore statistics for
the logical type (e.g. I believe sort order for float16 doesn't correspond to
signed comparison)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
