paleolimbot commented on code in PR #488:
URL: https://github.com/apache/arrow-nanoarrow/pull/488#discussion_r1621036563
##########
extensions/nanoarrow_device/src/nanoarrow/nanoarrow_device_cuda.c:
##########
@@ -105,19 +140,19 @@ static ArrowErrorCode
ArrowDeviceCudaAllocateBuffer(struct ArrowDevice* device,
buffer->allocator =
ArrowBufferDeallocator(&ArrowDeviceCudaDeallocator, allocator_private);
- cudaSetDevice(prev_device);
+ cuCtxPopCurrent(&unused);
return NANOARROW_OK;
}
struct ArrowDeviceCudaArrayPrivate {
struct ArrowArray parent;
- cudaEvent_t sync_event;
+ CUevent cu_event;
};
Review Comment:
This can now be specified from `ArrowDeviceArrayInit()`! I have a feeling I
will be needing it shortly in the async buffer copying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
