kou commented on PR #37822:
URL: https://github.com/apache/arrow/pull/37822#issuecomment-2142976887
> Of these - the testing platforms, I think it could go down to just node
and chrome. Going down to just node is a possibility, but I think slightly
risky, because system calls including files, dates and times etc. are handled
differently between node and browser.
It makes sense. Let's choose the approach.
> I think the INSTALL_LIBDIR is right, because with it disabled, we install
into emscripten sysroot, which makes python build work nicely.
It means that we should use `INSTALL_LIBDIR` not `CMAKE_INSTALL_LIBDIR`,
right?
I think that it's not related.
Can we specify Emscripten sysroot as `ARROW_HOME` instead of removing
`-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX:-${ARROW_HOME}}`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
