tustvold commented on issue #5827: URL: https://github.com/apache/arrow-rs/issues/5827#issuecomment-2143404028
It turns out I actually flagged this on the original PR that altered the timezone casting logic - https://github.com/apache/arrow-rs/pull/4201#discussion_r1192301482 The argument that convinced me in the end is that when parsing from a string we convert to UTC ``` let array = StringArray::from(vec!["2010-01-01T00:00:00.123456+08:00"]); let data_type = DataType::Timestamp(TimeUnit::Nanosecond, None); let cast = cast(&array, &data_type).unwrap(); let value = cast.as_primitive::<TimestampNanosecondType>().value_as_datetime(0).unwrap(); assert_eq!(value.to_string(), "2009-12-31 16:00:00.123456"); ``` But perhaps we want to change this also? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
