kou commented on issue #41919: URL: https://github.com/apache/arrow/issues/41919#issuecomment-2143719349
> By "this" I assume you mean the suggestion I made in the linked issue to change SetToken to take a shared_ptr argument by value instead of a raw pointer. Right. > our server rotates authentication tokens after a period of time, and keeps the old one valid for a while after it has been rotated If a server does it and a client is used only for one user, it doesn't use wrong authentication as you said. But, in general, `FlightClient` can't assume them. For example, a client may be shared with multiple users. I don't object this approach because it's better than crashing. Could you open a PR? But I think that we still need to update our documentation even with this change: https://github.com/apache/arrow/issues/38565#issuecomment-1800131268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
