kou commented on code in PR #41888:
URL: https://github.com/apache/arrow/pull/41888#discussion_r1623338074
##########
.pre-commit-config.yaml:
##########
@@ -141,3 +141,17 @@ repos:
'--disable',
'dangling-hyphen,line-too-long',
]
+ - repo: https://github.com/golangci/golangci-lint
+ rev: v1.59.0
+ hooks:
+ # no built-in support for multiple go.mod
+ # https://github.com/golangci/golangci-lint/issues/828
+ - id: golangci-lint
+ name: golangci-lint-full-arrow
+ entry: bash -c 'cd go/arrow && golangci-lint run'
+ - id: golangci-lint
+ name: golangci-lint-full-parquet
+ entry: bash -c 'cd go/parquet && golangci-lint run'
+ - id: golangci-lint
Review Comment:
```suggestion
- id: golangci-lint-full
```
##########
.pre-commit-config.yaml:
##########
@@ -141,3 +141,17 @@ repos:
'--disable',
'dangling-hyphen,line-too-long',
]
+ - repo: https://github.com/golangci/golangci-lint
+ rev: v1.59.0
+ hooks:
+ # no built-in support for multiple go.mod
+ # https://github.com/golangci/golangci-lint/issues/828
+ - id: golangci-lint
+ name: golangci-lint-full-arrow
+ entry: bash -c 'cd go/arrow && golangci-lint run'
+ - id: golangci-lint
Review Comment:
```suggestion
- id: golangci-lint-full
```
##########
.golangci.yaml:
##########
Review Comment:
Could you add our license header to this file?
##########
.pre-commit-config.yaml:
##########
@@ -141,3 +141,17 @@ repos:
'--disable',
'dangling-hyphen,line-too-long',
]
+ - repo: https://github.com/golangci/golangci-lint
+ rev: v1.59.0
+ hooks:
+ # no built-in support for multiple go.mod
+ # https://github.com/golangci/golangci-lint/issues/828
+ - id: golangci-lint
Review Comment:
```suggestion
- id: golangci-lint-full
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
