vibhatha commented on code in PR #39777:
URL: https://github.com/apache/arrow/pull/39777#discussion_r1624324931
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/rounding/DefaultRoundingPolicy.java:
##########
@@ -44,20 +44,16 @@ public class DefaultRoundingPolicy implements
RoundingPolicy {
static {
int defaultPageSize =
Integer.getInteger("org.apache.memory.allocator.pageSize", 8192);
- Throwable pageSizeFallbackCause = null;
try {
validateAndCalculatePageShifts(defaultPageSize);
} catch (Throwable t) {
- pageSizeFallbackCause = t;
defaultPageSize = 8192;
}
int defaultMaxOrder =
Integer.getInteger("org.apache.memory.allocator.maxOrder", 11);
- Throwable maxOrderFallbackCause = null;
try {
validateAndCalculateChunkSize(defaultPageSize, defaultMaxOrder);
} catch (Throwable t) {
- maxOrderFallbackCause = t;
Review Comment:
I see, how should we log this, any preferred practice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
