lidavidm commented on PR #41927: URL: https://github.com/apache/arrow/pull/41927#issuecomment-2145113816
That said, this doesn't seem like a guaranteed fix. https://stackoverflow.com/a/47117985/262727 Mutating the shared_ptr while another thread is copying it is still thread-unsafe, just perhaps a little less likely to cause problems than before. I'd still want to at least document the API as thread-unsafe while perhaps allowing this PR to avoid some basic errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
