vibhatha commented on code in PR #40520:
URL: https://github.com/apache/arrow/pull/40520#discussion_r1625255057
##########
dev/archery/archery/linking.py:
##########
@@ -61,9 +63,84 @@ def list_dependency_names(self):
names.append(name)
return names
+ def _remove_weak_symbols(self, symbol_info):
+ return [line for line in symbol_info if not line.endswith(
+ (" v", " V", " w", " W"))]
+
+ def _remove_symbol_versions(self, symbol_info):
+ return [line.split('@')[0].strip() for line in symbol_info]
+
+ def list_symbols_for_dependency(self, dependency,
remove_symbol_versions=False):
Review Comment:
It is true that we use `self.path` to get all the other paths and get the
libraries path, we could fold everything into just one function and remove this
function if required. But my intention was to keep a util function which can
list dependencies for a particular library path. Am I wrong here? Can we do
better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
