lidavidm commented on code in PR #41930:
URL: https://github.com/apache/arrow/pull/41930#discussion_r1625276849
##########
java/c/src/main/java/org/apache/arrow/c/StructVectorLoader.java:
##########
@@ -54,7 +55,12 @@ public class StructVectorLoader {
/**
* Construct with a schema.
- *
+ * <p>
+ * The schema referred to here can be obtained from the struct vector.
+ * Consider a {@link StructVector} structVector, the schema can be obtained
as follows:
+ * <code>
+ * Schema schema = new Schema(structVector.getField().getChildren());
+ * </code>
Review Comment:
```suggestion
* <p>
* The schema here should be the children of a struct vector, not a schema
* containing the struct field itself. For example:
* <code>
* Schema schema = new Schema(structVector.getField().getChildren());
* </code>
```
##########
java/c/src/main/java/org/apache/arrow/c/StructVectorLoader.java:
##########
@@ -54,7 +55,12 @@ public class StructVectorLoader {
/**
* Construct with a schema.
- *
+ * <p>
+ * The schema referred to here can be obtained from the struct vector.
+ * Consider a {@link StructVector} structVector, the schema can be obtained
as follows:
+ * <code>
+ * Schema schema = new Schema(structVector.getField().getChildren());
+ * </code>
Review Comment:
```suggestion
* <p>
* The schema here should be the children of a struct vector, not a schema
* containing the struct field itself. For example:
* <code>
* Schema schema = new Schema(structVector.getField().getChildren());
* </code>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
