jorisvandenbossche commented on code in PR #41757:
URL: https://github.com/apache/arrow/pull/41757#discussion_r1625867013
##########
cpp/src/arrow/array/array_nested.cc:
##########
@@ -836,24 +845,32 @@ Result<std::shared_ptr<Array>>
MapArray::FromArraysInternal(
using OffsetArrayType = typename TypeTraits<OffsetArrowType>::ArrayType;
const auto& typed_offsets = checked_cast<const OffsetArrayType&>(*offsets);
- auto buffers = BufferVector({nullptr, typed_offsets.values()});
+
+ BufferVector buffers;
+ int64_t null_count;
+ if (null_bitmap != nullptr) {
+ buffers = BufferVector({std::move(null_bitmap), typed_offsets.values()});
+ null_count = null_bitmap->size();
Review Comment:
> might be sum of bits at that time (1 for each missing/null
Note that for null_count don't want the sum / count of set bits, but the
count of unset bits (as this is a validity_bitmap, although the keyword is
confusingly named null_bitmap)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
