felipecrv commented on code in PR #41925:
URL: https://github.com/apache/arrow/pull/41925#discussion_r1628001206
##########
cpp/src/arrow/compute/expression_test.cc:
##########
@@ -909,6 +909,39 @@ TEST(Expression, ExecuteCallWithNoArguments) {
EXPECT_EQ(actual.length(), kCount);
}
+TEST(Expression, ExecuteChunkedArray) {
Review Comment:
> Because the comment #41923 (comment) mentioned that function kernel with
NullHandling::type::COMPUTED_NO_PREALLOCATE will return chunked-array when the
input is chunked-array.
I am not sure always expecting chunked-array as output should be tested. The
implication from `COMPUTED_NO_PREALLOCATE` should be regarded as an unstable
internal implementation choice.
> And also, we should add chunked-array support to MakeExecBatch, because
the expression system can handle chunked-array normally, so this can be opened
as a separate issue include simplify these tests by ExpectExecute.
Not really because `ExecBatch` should only contain scalars and simple arrays.
The right move is (probably) making `ExecuteScalarExpression` take
`std::vector<Datum>` when a `ExecBatch` can't be built and pass that through
the kernel matching logic that discerns between chunked and flat arrays.
There are many existing kernels taking `ExecBatch` assuming the input is
either scalar or array, so you can't really transport more than that inside an
`ExecBatch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
