alamb opened a new issue, #5846:
URL: https://github.com/apache/arrow-rs/issues/5846

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   
   @advancedxy  noted in 
https://github.com/apache/datafusion/pull/10738/files#r1627775856 that keeping 
track of skip/scan in coe like
   
   ```rust
   let row_selection = RowSelection::from(vec![
       RowSelector::skip(100),
       RowSelector::select(100),
       RowSelector::skip(150),
       RowSelector::select(50),
   ])
   ```
   
    is hard and it is easier to undersand and more concise to use 
`from_consecutive_ranges`
   
   ```rust 
   let row_selection = RowSelection::from_consecutive_ranges(vec![100..200, 
350..400]);
   ```
   
   Sadly, this function is not public:
   ```
   This is a great idea 
   
   I tried it, and sadly it seems the `from_consecutive_ranges` is a private 
function. 
   
   ```
   error[E0624]: associated function `from_consecutive_ranges` is private
      --> 
datafusion/core/src/datasource/physical_plan/parquet/access_plan.rs:43:35
       |
   11  |   let row_selection = 
RowSelection::from_consecutive_ranges(vec![100..200, 350..400]);
       |                                     ^^^^^^^^^^^^^^^^^^^^^^^ private 
associated function
       |
      ::: 
/Users/andrewlamb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/parquet-51.0.0/src/arrow/arrow_reader/selection.rs:118:5
       |
   118 | /     pub(crate) fn from_consecutive_ranges<I: Iterator<Item = 
Range<usize>>>(
   119 | |         ranges: I,
   120 | |         total_rows: usize,
   121 | |     ) -> Self {
   ```
   ```
   
   **Describe the solution you'd like**
   Make `RowSelection::from_consecutive_ranges` public so it can be used by 
other crates 
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features 
you've considered.
   -->
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to