lidavidm commented on code in PR #41772:
URL: https://github.com/apache/arrow/pull/41772#discussion_r1628574450
##########
java/flight/flight-core/pom.xml:
##########
@@ -151,13 +150,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <!--
- Downgrade maven-shade-plugin specifically for this module.
- Using a newer version up to at least 3.5.1 will cause
- issues in the arrow-tools tests looking up FlatBuffer
- dependencies.
- -->
- <version>3.2.4</version>
Review Comment:
Hmm, why does this not apply anymore? We saw problems last time we tried to
upgrade
##########
ci/scripts/java_full_build.sh:
##########
@@ -60,10 +57,6 @@ mvn clean \
-DdescriptorId=source-release
# copy all jar, zip and pom files to the distribution folder
-find . \
- "(" -name "*-javadoc.jar" -o -name "*-sources.jar" ")" \
- -exec echo {} ";" \
- -exec cp {} $dist_dir ";"
Review Comment:
This is covered by the line below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
