nevi-me commented on a change in pull request #9496:
URL: https://github.com/apache/arrow/pull/9496#discussion_r582549593



##########
File path: rust/arrow/src/buffer/immutable.rs
##########
@@ -36,7 +36,7 @@ use super::MutableBuffer;
 #[derive(Clone, PartialEq, Debug)]
 pub struct Buffer {
     /// the internal byte buffer.
-    data: Arc<Bytes>,
+    data: Arc<Bytes<u8>>,

Review comment:
       @jorgecarleitao if Buffer always has `Bytes<u8>`, I think this alone 
doesn't address one of the motivations of doing this; being that we'd like to 
know what boundary to slice buffers in when offsetting arrays.
   
   This would be when using `Buffer::offset` and `Buffer::length` on nested 
arrays.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to